This commit is contained in:
Mars 2025-05-03 02:11:25 -04:00
parent f5c138bc86
commit 84df352751
Signed by: pupbrained
GPG key ID: 0FF5B8826803F895

View file

@ -43,16 +43,13 @@ namespace {
mib[2] = pid;
mib[3] = KERN_PROC_PATHNAME; // The specific subcommand
if (sysctl(mib, 4, exePathBuf.data(), &size, nullptr, 0) == -1) {
// Fallback for older systems or if KERN_PROC_PATHNAME is restricted/unavailable
// Note: KERN_PROC_ARGS might give args too, need parsing.
// For simplicity, we'll just report the error for now.
if (sysctl(mib, 4, exePathBuf.data(), &size, nullptr, 0) == -1)
return Err(DracError::withErrno(std::format("sysctl KERN_PROC_PATHNAME failed for pid {}", pid)));
}
if (size == 0 || exePathBuf[0] == '\0') {
return Err(DracError(DracErrorCode::NotFound, std::format("sysctl KERN_PROC_PATHNAME returned empty path for pid {}", pid)));
}
if (size == 0 || exePathBuf[0] == '\0')
return Err(
DracError(DracErrorCode::NotFound, std::format("sysctl KERN_PROC_PATHNAME returned empty path for pid {}", pid))
);
exePathBuf[std::min(size, exePathBuf.size() - 1)] = '\0';
@ -151,52 +148,48 @@ namespace {
pid_t peer_pid = -1; // Initialize PID
#if defined(__FreeBSD__) || defined(__DragonFly__)
struct xucred cred; // Use xucred on FreeBSD/DragonFly
socklen_t len = sizeof(cred);
if (getsockopt(fileDescriptor, SOL_SOCKET, LOCAL_PEERCRED, &cred, &len) == -1) {
return Err(DracError::withErrno("Failed to get socket credentials (LOCAL_PEERCRED)"));
}
if (len != sizeof(cred) || cred.cr_version != XUCRED_VERSION) {
return Err(DracError(DracErrorCode::PlatformSpecific, "Invalid xucred structure received"));
}
peer_pid = cred.cr_pid; // <<< Get PID from xucred
struct xucred cred;
socklen_t len = sizeof(cred);
if (getsockopt(fileDescriptor, SOL_SOCKET, LOCAL_PEERCRED, &cred, &len) == -1)
return Err(DracError::withErrno("Failed to get socket credentials (LOCAL_PEERCRED)"));
if (len != sizeof(cred) || cred.cr_version != XUCRED_VERSION)
return Err(DracError(DracErrorCode::PlatformSpecific, "Invalid xucred structure received"));
peer_pid = cred.cr_pid;
#elif defined(__NetBSD__)
uid_t euid;
gid_t egid;
if (getpeereid(fileDescriptor, &euid, &egid) == -1) {
if (getpeereid(fileDescriptor, &euid, &egid) == -1)
return Err(DracError::withErrno("getpeereid failed on Wayland socket"));
}
return "Wayland Compositor (Unknown Path)";
#endif
if (peer_pid <= 0) {
if (peer_pid <= 0)
return Err(DracError(DracErrorCode::PlatformSpecific, "Failed to obtain a valid peer PID"));
}
// --- Use the helper function to get the path ---
Result<String, DracError> exePathResult = GetPathByPid(peer_pid);
if (!exePathResult) {
// Forward the error from GetPathByPid
return Err(std::move(exePathResult).error());
}
const String& exeRealPath = *exePathResult;
// --- Extract filename from path (OS-independent) ---
StringView compositorNameView;
if (const usize lastSlash = exeRealPath.rfind('/'); lastSlash != String::npos) {
if (const usize lastSlash = exeRealPath.rfind('/'); lastSlash != String::npos)
compositorNameView = StringView(exeRealPath).substr(lastSlash + 1);
} else {
compositorNameView = exeRealPath; // Path is just the filename
}
else
compositorNameView = exeRealPath;
if (compositorNameView.empty() || compositorNameView == "." || compositorNameView == "/")
return Err(DracError(DracErrorCode::NotFound, "Failed to get compositor name from path"));
// --- Heuristic cleanup (OS-independent) ---
if (constexpr StringView wrappedSuffix = "-wrapped"; compositorNameView.length() > 1 + wrappedSuffix.length() &&
compositorNameView[0] == '.' && compositorNameView.ends_with(wrappedSuffix)) {
const StringView cleanedView =
@ -238,6 +231,7 @@ namespace os {
}
utsname uts;
if (uname(&uts) == -1)
return Err(DracError::withErrno(std::format("Failed to open {} and uname() call also failed", path)));
@ -447,39 +441,32 @@ namespace os {
usize size = buffer.size();
#if defined(__FreeBSD__) || defined(__DragonFly__)
// Use kenv on FreeBSD / DragonFly
int result = kenv(KENV_GET, "smbios.system.product", buffer.data(), buffer.size() - 1); // Ensure space for null
if (result == -1) {
// Fallback: Maybe try hw.model?
if (sysctlbyname("hw.model", buffer.data(), &size, nullptr, 0) == -1) {
if (sysctlbyname("hw.model", buffer.data(), &size, nullptr, 0) == -1)
return Err(DracError::withErrno("kenv smbios.system.product failed and sysctl hw.model also failed"));
}
buffer[std::min(size, buffer.size() - 1)] = '\0'; // Null terminate sysctl result
buffer[std::min(size, buffer.size() - 1)] = '\0';
return String(buffer.data());
}
// kenv should null-terminate, but let's be safe if result > 0 (bytes written)
if (result > 0) buffer[result] = '\0';
else buffer[0] = '\0'; // Ensure null if result was 0 (empty string?)
if (result > 0)
buffer[result] = '\0';
else
buffer[0] = '\0';
#elif defined(__NetBSD__)
// Use sysctl on NetBSD
constexpr const char* netbsd_mib = "machdep.dmi.system-product";
if (sysctlbyname(netbsd_mib, buffer.data(), &size, nullptr, 0) == -1) {
// Fallback: Try hw.model on NetBSD too
size = buffer.size(); // reset size for next attempt
if (sysctlbyname("hw.model", buffer.data(), &size, nullptr, 0) == -1) {
return Err(DracError::withErrno(std::format("sysctlbyname failed for both {} and hw.model", netbsd_mib)));
}
}
// Ensure null termination for sysctl results
if (sysctlbyname("machdep.dmi.system-product", buffer.data(), &size, nullptr, 0) == -1)
return Err(DracError::withErrno(std::format("sysctlbyname failed for")));
buffer[std::min(size, buffer.size() - 1)] = '\0';
#endif
// Ensure the buffer isn't empty before returning
if(buffer[0] == '\0') {
if (buffer[0] == '\0')
return Err(DracError(DracErrorCode::NotFound, "Failed to get host product information (empty result)"));
}
return String(buffer.data());}
return String(buffer.data());
}
fn GetKernelVersion() -> Result<String, DracError> {
utsname uts;
@ -508,4 +495,4 @@ namespace os {
fn GetPackageCount() -> Result<u64, DracError> { return shared::GetPackageCount(); }
} // namespace os
#endif // __FreeBSD__ || __DragonFly__
#endif // __FreeBSD__ || __DragonFly__ || __NetBSD__